Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AcyclicTransformer helper #82

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Add AcyclicTransformer helper #82

merged 1 commit into from
Mar 26, 2018

Conversation

dsnet
Copy link
Collaborator

@dsnet dsnet commented Mar 21, 2018

Add AcyclicTransformer helper, which wraps Transformer with a FilterPath
that ensures that the transformer cannot be recursively applied upon
the output of itself. Adjust documentation of Transformer to suggest usage
of AcyclicTransformer if necessary.

Fixes #77

@dsnet
Copy link
Collaborator Author

dsnet commented Mar 26, 2018

@neild, did you have any suggestions on the name? Or does AcyclicTransformer SGTY?

@neild
Copy link
Collaborator

neild commented Mar 26, 2018

AcyclicTransformer SGTM. It's a mouthful and not really explanatory enough to understand what it does absent the documentation, but strikes a decent balance between being too verbose and meaningless. I can't think of anything better.

Add AcyclicTransformer helper, which wraps Transformer with a FilterPath
that ensures that the transformer cannot be recursively applied upon
the output of itself. Adjust documentation of Transformer to suggest usage
of AcyclicTransformer if necessary.

Fixes #77
@dsnet dsnet merged commit 7d08676 into master Mar 26, 2018
@dsnet dsnet deleted the cmpopts-xform branch March 26, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants