Enforce proper sha256 usage (#1544)

google · Jan 26, 2023 · 11843ba · 11843ba
1 parent 76bac93
commit 11843ba
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -32,3 +32,9 @@ linters:
 
   disable:
   - errcheck
+
+linters-settings:
+  depguard:
+    include-go-root: true
+    packages-with-error-message:
+    - crypto/sha256: "use crypto.SHA256 instead"
diff --git a/pkg/name/digest.go b/pkg/name/digest.go
@@ -15,6 +15,7 @@
 package name
 
 import (
+	// nolint: depguard
 	_ "crypto/sha256" // Recommended by go-digest.
 	"strings"
 

diff --git a/pkg/registry/registry_test.go b/pkg/registry/registry_test.go
@@ -15,7 +15,6 @@
 package registry_test
 
 import (
-	"bytes"
 	"fmt"
 	"io"
 	"log"
@@ -47,7 +46,7 @@ const (
 )
 
 func sha256String(s string) string {
-	h, _, _ := v1.SHA256(bytes.NewReader([]byte(s)))
+	h, _, _ := v1.SHA256(strings.NewReader(s))
 	return h.Hex
 }