-
Notifications
You must be signed in to change notification settings - Fork 527
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make sure options are propagated to child Writes (#818)
* Make sure options are propagated to child Writes Right now we are just passing through cherrypicked options from WriteIndex to other WriteIndex and Write calls. This isn't sustainable as we add more options, since we'd have to keep these in sync. Instead, for WriteIndex, we can reuse the writer by pulling the implementation out into writer.writeIndex. For Write, since we do scope calculation based on layers, we can't reuse the writer because we don't do scope calculation for WriteIndex.
- Loading branch information
1 parent
6a63025
commit 5fa6b58
Showing
3 changed files
with
56 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters