-
Notifications
You must be signed in to change notification settings - Fork 528
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
skip tls verification if default transport is used with insecure opti…
…on (#1559) Signed-off-by: Jose R. Gonzalez <jose@flutes.dev>
- Loading branch information
Showing
6 changed files
with
121 additions
and
650 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
// Copyright 2023 Google LLC All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package crane | ||
|
||
import ( | ||
"errors" | ||
"net/http" | ||
"testing" | ||
|
||
"github.com/google/go-containerregistry/pkg/v1/remote" | ||
) | ||
|
||
func TestInsecureOptionTracking(t *testing.T) { | ||
want := true | ||
opts := GetOptions(Insecure) | ||
|
||
if got := opts.insecure; got != want { | ||
t.Errorf("got %t\nwant: %t", got, want) | ||
} | ||
} | ||
|
||
func TestTransportSetting(t *testing.T) { | ||
opts := GetOptions(WithTransport(remote.DefaultTransport)) | ||
|
||
if opts.transport == nil { | ||
t.Error("expected crane transport to be set when user passes WithTransport") | ||
} | ||
} | ||
|
||
func TestInsecureTransport(t *testing.T) { | ||
want := true | ||
opts := GetOptions(Insecure) | ||
var transport *http.Transport | ||
var ok bool | ||
if transport, ok = opts.transport.(*http.Transport); !ok { | ||
t.Fatal("Unable to successfully assert default transport") | ||
} | ||
|
||
if transport.TLSClientConfig == nil { | ||
t.Fatal(errors.New("TLSClientConfig was nil and should be set")) | ||
} | ||
|
||
if got := transport.TLSClientConfig.InsecureSkipVerify; got != want { | ||
t.Errorf("got: %t\nwant: %t", got, want) | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.