Drop error return for mutate.Annotations (#1058)

cmd/crane/cmd/mutate.go

@@ -91,11 +91,7 @@ func NewCmdMutate(options *[]crane.Option) *cobra.Command {
 				log.Fatalf("mutating config: %v", err)
 			}
 
-			// Mutate and write image.
-			img, err = mutate.Annotations(img, annotations)
-			if err != nil {
-				log.Fatalf("mutating annotations: %v", err)
-			}
+			img = mutate.Annotations(img, annotations)
 
 			// If the new ref isn't provided, write over the original image.
 			// If that ref was provided by digest (e.g., output from

pkg/v1/mutate/mutate.go

@@ -114,13 +114,11 @@ func Config(base v1.Image, cfg v1.Config) (v1.Image, error) {
 }
 
 // Annotations mutates the provided v1.Image to have the provided annotations
-func Annotations(base v1.Image, annotations map[string]string) (v1.Image, error) {
-	image := &image{
+func Annotations(base v1.Image, annotations map[string]string) v1.Image {
+	return &image{
 		base:        base,
 		annotations: annotations,
 	}
-
-	return image, nil
 }
 
 // ConfigFile mutates the provided v1.Image to have the provided v1.ConfigFile

pkg/v1/mutate/mutate_test.go

@@ -273,10 +273,7 @@ func TestAnnotations(t *testing.T) {
 		"im.the.first.annotation": "hello world",
 	}
 
-	result, err := mutate.Annotations(source, newAnnotations)
-	if err != nil {
-		t.Fatalf("failed to mutate annotations: %v", err)
-	}
+	result := mutate.Annotations(source, newAnnotations)
 
 	if configDigestsAreEqual(t, source, result) {
 		t.Errorf("mutating the manifest annotations MUST mutate the config digest")