-
Notifications
You must be signed in to change notification settings - Fork 527
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't reuse errgroups, propagate contexts better (#1128)
When you Wait() on an errgroup, the underlying context gets cancelled, so calling Wait() twice will break if you correctly propagate contexts. We weren't propagating contexts correctly, so this kind of worked before, but if we actually want to leverage contexts better we should fix this :)
- Loading branch information
1 parent
b5cf9c4
commit c71ca9b
Showing
3 changed files
with
40 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters