Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request - zstd/compression support in crane copy #1501

Open
kapilt opened this issue Dec 6, 2022 · 11 comments
Open

feature request - zstd/compression support in crane copy #1501

kapilt opened this issue Dec 6, 2022 · 11 comments
Labels
lifecycle/frozen question Further information is requested

Comments

@kapilt
Copy link

kapilt commented Dec 6, 2022

I'd like to be able to crane copy to be able to switch compressions (zstd <-> gzip) when copying. there's a lot of tools that only support one or the other, and using crane as a utility to enable that is really helpful. we already use it as a utility for slicing multi-arch images when other runtimes/tools don't support multi-arch.
@kapilt kapilt added the question Further information is requested label Dec 6, 2022
@jonjohnsonjr
Copy link
Collaborator

I don't think we would add this as part of crane copy because it would mutate the images (and thus digests), so it's not really a "copy". Maybe as part of crane mutate?

@kapilt
Copy link
Author

kapilt commented Jan 10, 2023

Part of mutate sounds good.

@misha-ridge
Copy link

Another place where it will be useful is crane append.

@github-actions
Copy link

github-actions bot commented May 8, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@misha-ridge
Copy link

not fixed yet

@slonopotamus slonopotamus mentioned this issue Jul 14, 2023
Closed
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@misha-ridge
Copy link

not fixed yet, and I don't know how to add lifecycle/frozen

slonopotamus added a commit to slonopotamus/go-containerregistry that referenced this issue Oct 28, 2023
@slonopotamus
Add support for zstd layer upload
4ccbd50 
It is now possible to `crane append -f bla.tar.zstd` to upload Zstd layer, both from file and from pipe.

Before this commit, crane would erroneously upload such layer with gzip mime type.

While this PR does not _fully_ solve google#1501, it is very close to that.

Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
@slonopotamus slonopotamus mentioned this issue Oct 28, 2023
Open
slonopotamus added a commit to slonopotamus/go-containerregistry that referenced this issue Oct 29, 2023
@slonopotamus
Add support for zstd layer upload
db6ecc9 
It is now possible to `crane append -f bla.tar.zstd` to upload Zstd layer, both from file and from pipe.

Before this commit, crane would erroneously upload such layer with gzip mime type.

While this PR does not _fully_ solve google#1501, it is very close to that.

Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
slonopotamus added a commit to slonopotamus/go-containerregistry that referenced this issue Oct 29, 2023
@slonopotamus
Add support for zstd layer upload
0d4e78f 
It is now possible to `crane append -f bla.tar.zstd` to upload Zstd layer, both from file and from pipe.

Before this commit, crane would erroneously upload such layer with gzip mime type.

While this PR does not _fully_ solve google#1501, it is very close to that.

Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
slonopotamus added a commit to slonopotamus/go-containerregistry that referenced this issue Oct 29, 2023
@slonopotamus
Add support for zstd layer upload
49b2380 
It is now possible to `crane append -f bla.tar.zstd` to upload Zstd layer, both from file and from pipe.

Before this commit, crane would erroneously upload such layer with gzip mime type.

While this PR does not _fully_ solve google#1501, it is very close to that.

Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
slonopotamus added a commit to slonopotamus/go-containerregistry that referenced this issue Oct 29, 2023
@slonopotamus
Add support for zstd layer upload
2161e22 
It is now possible to `crane append -f bla.tar.zstd` to upload Zstd layer, both from file and from pipe.

Before this commit, crane would erroneously upload such layer with gzip mime type.

While this PR does not _fully_ solve google#1501, it is very close to that.

Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
slonopotamus added a commit to slonopotamus/go-containerregistry that referenced this issue Oct 29, 2023
@slonopotamus
Add support for zstd layer upload
90eea67 
It is now possible to `crane append -f bla.tar.zstd` to upload Zstd layer, both from file and from pipe.

Before this commit, crane would erroneously upload such layer with gzip mime type.

While this PR does not _fully_ solve google#1501, it is very close to that.

Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@slonopotamus
Copy link

Not stale, there are two PRs that try to address this issue.

ethan-gallant pushed a commit to ethan-gallant/go-containerregistry that referenced this issue Dec 13, 2023
@slonopotamus @ethan-gallant
Add support for zstd layer upload
c32386c 
It is now possible to `crane append -f bla.tar.zstd` to upload Zstd layer, both from file and from pipe.

Before this commit, crane would erroneously upload such layer with gzip mime type.

While this PR does not _fully_ solve google#1501, it is very close to that.

Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
ethan-gallant pushed a commit to ethan-gallant/go-containerregistry that referenced this issue Feb 7, 2024
@slonopotamus @ethan-gallant
Add support for zstd layer upload
97ff863 
It is now possible to `crane append -f bla.tar.zstd` to upload Zstd layer, both from file and from pipe.

Before this commit, crane would erroneously upload such layer with gzip mime type.

While this PR does not _fully_ solve google#1501, it is very close to that.

Signed-off-by: Marat Radchenko <marat@slonopotamus.org>
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@slonopotamus
Copy link

Weird bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kapilt @slonopotamus @jonjohnsonjr @thesayyn @misha-ridge