Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add unit tests for list.go #1670

Closed
khareyash05 opened this issue Apr 24, 2023 · 5 comments
Closed

feat : add unit tests for list.go #1670

khareyash05 opened this issue Apr 24, 2023 · 5 comments

Comments

@khareyash05
Copy link

I would like to add unit tests for link.go

@imjasonh
Copy link
Collaborator

Are there any specific tests you had in mind? In general the code in pkg/crane is intended to be a little higher-level and user-friendly than the equivalent code in pkg/v1/remote, but since it's otherwise the same code we mostly just test pkg/v1/remote.

If there's meaningful code in pkg/crane that you think deserves tests please send a PR and we can discuss it!

Thanks!

@khareyash05
Copy link
Author

Thank you! Since pkg/v1/remote is more used there is no need to add specific tests according to me.However I saw some files in pkg/v1/remote like puller.go and pusher.go which have missing test files. Would you like me to add tests to the files? @imjasonh

@imjasonh
Copy link
Collaborator

@jonjohnsonjr recently added these files (they're not yet released), so missing unit tests aren't a huge concern at the moment. If there's something you'd like to add tests for, though, please feel free and cc @jonjohnsonjr on any PRs.

@jonjohnsonjr
Copy link
Collaborator

They're fairly well covered by #1672 which made all the other entrypoints go through Pusher and Puller, but we could probably use some tests that explicitly exercise pusher and puller.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants