-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8schain's k8s dependency to 0.21.0 #1001
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1001 +/- ##
=======================================
Coverage 75.33% 75.33%
=======================================
Files 107 107
Lines 5036 5036
=======================================
Hits 3794 3794
Misses 701 701
Partials 541 541 Continue to review full report at Codecov.
|
edit: Upon closer inspection this isn't the case! It's included in v1.21.0, not included in v1.20.0. It was the |
Do we need to bump cc @vdemeester |
@jonjohnsonjr we probably should indeed |
|
vdemeester/k8s-pkg-credentialprovider#10 is merged |
Why do we need all the replace directives? |
Yeah agreed, I think we should try to get rid of the |
I think I need to fix something of k8s-pkg-credentialprovider though |
Accordingly update github.com/vdemeester/k8s-pkg-credentialprovider to v1.21.0-1
It is done, @imjasonh updated to 1.21.0-1 👼🏼 |
This reverts commit f009e5f.
This reverts commit f009e5f.
#997 (comment)
I edited
go.mod
to bump the versions, then rango mod download
as recommended bygo build ./...
, thengo mod tidy
.