Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8schain's k8s dependency to 0.21.0 #1001

Merged
merged 1 commit into from
May 5, 2021

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Apr 26, 2021

#997 (comment)

I edited go.mod to bump the versions, then ran go mod download as recommended by go build ./..., then go mod tidy.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2021

Codecov Report

Merging #1001 (93acbed) into main (a58f1d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1001   +/-   ##
=======================================
  Coverage   75.33%   75.33%           
=======================================
  Files         107      107           
  Lines        5036     5036           
=======================================
  Hits         3794     3794           
  Misses        701      701           
  Partials      541      541           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a58f1d5...93acbed. Read the comment docs.

@imjasonh
Copy link
Collaborator Author

imjasonh commented Apr 26, 2021

It looks like the nondeterminism is still present in v1.21.0 :(

edit: Upon closer inspection this isn't the case! It's included in v1.21.0, not included in v1.20.0. It was the gitVersion line, not the gitCommit line, and we want to see %H and not %h

https://github.com/kubernetes/kubernetes/blob/v1.21.0/staging/src/k8s.io/component-base/version/base.go#L58

https://github.com/kubernetes/kubernetes/blob/v1.21.0/staging/src/k8s.io/client-go/pkg/version/base.go#L58

@jonjohnsonjr
Copy link
Collaborator

Do we need to bump github.com/vdemeester/k8s-pkg-credentialprovider?

cc @vdemeester

@vdemeester
Copy link
Contributor

@jonjohnsonjr we probably should indeed

@imjasonh
Copy link
Collaborator Author

@jonjohnsonjr we probably should indeed

vdemeester/k8s-pkg-credentialprovider#10

@imjasonh
Copy link
Collaborator Author

imjasonh commented May 3, 2021

@jonjohnsonjr
Copy link
Collaborator

Why do we need all the replace directives?

@vdemeester
Copy link
Contributor

Why do we need all the replace directives?

Yeah agreed, I think we should try to get rid of the replace as much as possible.

@vdemeester
Copy link
Contributor

I think I need to fix something of k8s-pkg-credentialprovider though

Accordingly update github.com/vdemeester/k8s-pkg-credentialprovider to v1.21.0-1
@vdemeester
Copy link
Contributor

I think I need to fix something of k8s-pkg-credentialprovider though

It is done, @imjasonh updated to 1.21.0-1 👼🏼

@imjasonh imjasonh merged commit f009e5f into google:main May 5, 2021
dprotaso added a commit to dprotaso/go-containerregistry that referenced this pull request May 31, 2021
dprotaso added a commit to dprotaso/go-containerregistry that referenced this pull request Jun 1, 2021
jonjohnsonjr pushed a commit that referenced this pull request Jun 1, 2021
* Revert "Update k8schain's k8s dependency to 0.21.0 (#1001)"

This reverts commit f009e5f.

* bump to k8s 1.20.7

* bump to k8s 1.21.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants