Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update actions #1015

Closed
wants to merge 1 commit into from
Closed

[main] Update actions #1015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/knative-boilerplate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ jobs:

steps:

- name: Set up Go 1.15.x
- name: Set up Go 1.16.x
uses: actions/setup-go@v2
with:
go-version: 1.15.x
go-version: 1.16.x
id: go

- name: Check out code
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/knative-go-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
name: Build
strategy:
matrix:
go-version: [1.15.x]
go-version: [1.16.x]
platform: [ubuntu-latest]

runs-on: ${{ matrix.platform }}
Expand All @@ -43,7 +43,13 @@ jobs:
- name: Check out code
uses: actions/checkout@v2

- id: go_mod
uses: andstor/file-existence-action@v1
with:
files: go.mod

- name: Build
if: ${{ steps.go_mod.outputs.files_exists == 'true' }}
run: |
tags="$(grep -I -r '// +build' . | \
grep -v '^./vendor/' | \
Expand All @@ -55,5 +61,4 @@ jobs:
tr '\n' ' ')"

echo "Building with tags: ${tags}"
go test -vet=off -tags "${tags}" -run=^$ ./... | grep -v "no test" || true

go test -vet=off -tags "${tags}" -run=^$ ./...
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line used to || true

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was invalid

2 changes: 1 addition & 1 deletion .github/workflows/knative-go-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
name: Unit Tests
strategy:
matrix:
go-version: [1.15.x]
go-version: [1.16.x]
platform: [ubuntu-latest]

runs-on: ${{ matrix.platform }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/knative-releasability.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ jobs:
echo "SLACK_WEBHOOK=exists" >> $GITHUB_ENV
fi

- name: Set up Go 1.15.x
- name: Set up Go 1.16.x
uses: actions/setup-go@v2
with:
go-version: 1.15.x
go-version: 1.16.x

- name: Install Dependencies
run: GO111MODULE=on go get knative.dev/test-infra/buoy@main
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/knative-style.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ jobs:
importpath: golang.org/x/tools/cmd/goimports

steps:
- name: Set up Go 1.15.x
- name: Set up Go 1.16.x
uses: actions/setup-go@v2
with:
go-version: 1.15.x
go-version: 1.16.x
id: go

- name: Check out code
Expand Down Expand Up @@ -89,10 +89,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Set up Go 1.15.x
- name: Set up Go 1.16.x
uses: actions/setup-go@v2
with:
go-version: 1.15.x
go-version: 1.16.x
id: go

- name: Check out code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/knative-verify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
name: Verify Deps and Codegen
strategy:
matrix:
go-version: [1.15.x]
go-version: [1.16.x]
platform: [ubuntu-latest]

runs-on: ${{ matrix.platform }}
Expand Down