Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-exec gcloud token source when we refresh #1017

Merged
merged 1 commit into from
May 13, 2021

Conversation

jonjohnsonjr
Copy link
Collaborator

Previously, this was storing a single exec.Command, but that gets
consumed when it gets Run, failing with:

exec: already started

This will re-exec the gcloud when needed.

Previously, this was storing a single exec.Command, but that gets
consumed when it gets Run, failing with:

exec: already started

This will re-exec the gcloud when needed.
@codecov-commenter
Copy link

Codecov Report

Merging #1017 (baae9ab) into main (4c244d6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   75.22%   75.22%           
=======================================
  Files         107      107           
  Lines        5053     5053           
=======================================
  Hits         3801     3801           
  Misses        706      706           
  Partials      546      546           
Impacted Files Coverage Δ
pkg/v1/google/auth.go 64.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c244d6...baae9ab. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit 21a2dc2 into google:main May 13, 2021
@jonjohnsonjr jonjohnsonjr deleted the gcloud-creds branch May 13, 2021 23:20
briandealwis added a commit to briandealwis/skaffold that referenced this pull request May 21, 2021
briandealwis added a commit to GoogleContainerTools/skaffold that referenced this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants