Add auth options to gcrane #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows overriding the use of gcrane.Keychain
imjasonh
reviewed
May 18, 2021
| // By default, gcrane will use gcrane.Keychain. | ||
| func WithKeychain(keys authn.Keychain) Option { | ||
| return func(o *options) { | ||
| // Replace the default keychain at position 0. |
There was a problem hiding this comment.
This feels gross, and brittle. Can we iterate options until we find the one to replace instead?
There was a problem hiding this comment.
I don't think it's possible :/
We had some discussion in #653 but I never came up with a better solution.
imjasonh
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows overriding the use of gcrane.Keychain