Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithTransport to gcrane #1022

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

Also add some silly tests for coverage.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #1022 (22d9e76) into main (4cdd086) will increase coverage by 0.15%.
The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
+ Coverage   75.22%   75.37%   +0.15%     
==========================================
  Files         107      107              
  Lines        5053     5076      +23     
==========================================
+ Hits         3801     3826      +25     
+ Misses        706      704       -2     
  Partials      546      546              
Impacted Files Coverage Δ
pkg/crane/options.go 90.47% <0.00%> (-9.53%) ⬇️
pkg/crane/catalog.go 100.00% <100.00%> (ø)
pkg/gcrane/options.go 100.00% <100.00%> (+22.22%) ⬆️
pkg/v1/remote/write.go 63.38% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b535fa...22d9e76. Read the comment docs.

Also add some silly tests for coverage.
@jonjohnsonjr jonjohnsonjr merged commit a27f4a4 into google:main Jun 11, 2021
@jonjohnsonjr jonjohnsonjr deleted the gcrane-transport branch June 11, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants