Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go1.16's module aware install vs tools.go #1028

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jun 1, 2021

go install module@version will install pinned versions of executables. Use this approach vs vendoring as it doesn't pollute our go.mod file and vendor directory

@codecov-commenter
Copy link

Codecov Report

Merging #1028 (b1ffede) into main (0233fcd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1028   +/-   ##
=======================================
  Coverage   75.03%   75.03%           
=======================================
  Files         107      107           
  Lines        5072     5072           
=======================================
  Hits         3806     3806           
  Misses        720      720           
  Partials      546      546           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0233fcd...b1ffede. Read the comment docs.

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@jonjohnsonjr
Copy link
Collaborator

Bless you.

@jonjohnsonjr jonjohnsonjr merged commit 100e16a into google:main Jun 1, 2021
@dprotaso dprotaso deleted the drop-tools-go branch June 1, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants