-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load manifest form tar file #1033
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
pkg/v1/tarball/image.go
Outdated
@@ -117,6 +117,22 @@ type Descriptor struct { | |||
// Manifest represents the manifests of all images as the `manifest.json` file in a `docker save` tarball. | |||
type Manifest []Descriptor | |||
|
|||
// LoadManifest load manifest | |||
func LoadManifest(path string) (Manifest, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we need this but I don't want the parameter to be a string
, so that you can use this for in-memory tarballs. Can you make this take an Opener
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
- Coverage 75.22% 75.03% -0.19%
==========================================
Files 107 107
Lines 5053 5079 +26
==========================================
+ Hits 3801 3811 +10
- Misses 706 725 +19
+ Partials 546 543 -3
Continue to review full report at Codecov.
|
Thanks! Can you squash these commits and make sure they are both authored as |
Signed-off-by: 刘畅 <basefly@outlook.com>
Fixes #1032