Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load manifest form tar file #1033

Merged
merged 1 commit into from
Jun 9, 2021
Merged

load manifest form tar file #1033

merged 1 commit into from
Jun 9, 2021

Conversation

hhstu
Copy link
Contributor

@hhstu hhstu commented Jun 3, 2021

Fixes #1032

@google-cla
Copy link

google-cla bot commented Jun 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@@ -117,6 +117,22 @@ type Descriptor struct {
// Manifest represents the manifests of all images as the `manifest.json` file in a `docker save` tarball.
type Manifest []Descriptor

// LoadManifest load manifest
func LoadManifest(path string) (Manifest, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we need this but I don't want the parameter to be a string, so that you can use this for in-memory tarballs. Can you make this take an Opener?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get

@google-cla
Copy link

google-cla bot commented Jun 8, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #1033 (1cd5b48) into main (4cdd086) will decrease coverage by 0.18%.
The diff coverage is 20.00%.

❗ Current head 1cd5b48 differs from pull request most recent head 02dacf6. Consider uploading reports for the commit 02dacf6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
- Coverage   75.22%   75.03%   -0.19%     
==========================================
  Files         107      107              
  Lines        5053     5079      +26     
==========================================
+ Hits         3801     3811      +10     
- Misses        706      725      +19     
+ Partials      546      543       -3     
Impacted Files Coverage Δ
pkg/crane/options.go 90.47% <0.00%> (-9.53%) ⬇️
pkg/gcrane/options.go 46.66% <0.00%> (-31.12%) ⬇️
pkg/v1/tarball/image.go 74.39% <0.00%> (-3.82%) ⬇️
pkg/v1/remote/write.go 63.59% <71.42%> (+0.63%) ⬆️
pkg/crane/catalog.go 100.00% <100.00%> (ø)
pkg/authn/keychain.go 100.00% <0.00%> (ø)
pkg/v1/remote/multi_write.go 58.95% <0.00%> (+2.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b535fa...02dacf6. Read the comment docs.

@jonjohnsonjr
Copy link
Collaborator

Thanks! Can you squash these commits and make sure they are both authored as hhstu for the CLA check?

Signed-off-by: 刘畅 <basefly@outlook.com>
@jonjohnsonjr jonjohnsonjr merged commit f0ce227 into google:main Jun 9, 2021
jonjohnsonjr pushed a commit that referenced this pull request Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A function just load manifest from tar file
3 participants