Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to add that crane retains the digest #1037

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Conversation

csantanapr
Copy link
Contributor

@csantanapr csantanapr commented Jun 3, 2021

Found about this little secret on Knative Slack channel that crane copy retains the digest value when copying images
Very important to know for some uses cases around security and secure supply chain

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #1037 (5c76498) into main (162d96e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   75.04%   75.04%           
=======================================
  Files         107      107           
  Lines        5074     5074           
=======================================
  Hits         3808     3808           
  Misses        720      720           
  Partials      546      546           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162d96e...5c76498. Read the comment docs.

@imjasonh
Copy link
Collaborator

imjasonh commented Jun 3, 2021

The markdown is generated, you'll want to update the source of truth here:

Short: "Efficiently copy a remote image from src to dst",

Signed-off-by: Carlos Santana <csantana@us.ibm.com>
@csantanapr
Copy link
Contributor Author

Thanks @imjasonh , updated the go file now

@imjasonh
Copy link
Collaborator

imjasonh commented Jun 4, 2021

You'll need to run ./hack/update-codegen.sh now to get the markdown generated from the Go code. Sorry for all the hoops to jump through.

@csantanapr
Copy link
Contributor Author

@imjasonh You're telling me that contributors to help out with markdown docs need to install Go and run Go on their computers? 🤣
You Go/k8s folks really love generators ❤️

Signed-off-by: Carlos Santana <csantana@us.ibm.com>
@csantanapr
Copy link
Contributor Author

@imjasonh I submitted the code-gen results, I used Go version 1.16 hope is ok with that version

@imjasonh
Copy link
Collaborator

imjasonh commented Jun 4, 2021

Yep! It's not ideal, but honestly I think this is the first time someone's contributed to these docs that wasn't already a contributor.

Thanks for putting up with it! ❤️

@imjasonh imjasonh merged commit 3bfab55 into google:main Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants