Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crane: ignore TLS certificate validation when using --insecure flag #1054

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Jun 16, 2021

when using the --insecure flag ignore the TLS validation.
Please let me know if this is ok or what are your thoughts

/assign @jonjohnsonjr

Fixes: #1024

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #1054 (9e0ece7) into main (529b437) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1054   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files         107      107           
  Lines        5087     5087           
=======================================
  Hits         3839     3839           
  Misses        703      703           
  Partials      545      545           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 529b437...9e0ece7. Read the comment docs.

cmd/crane/cmd/root.go Outdated Show resolved Hide resolved
cmd/crane/cmd/root.go Outdated Show resolved Hide resolved
cmd/crane/cmd/root.go Outdated Show resolved Hide resolved
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonjohnsonjr jonjohnsonjr merged commit 3bfd0b5 into google:main Jun 18, 2021
@cpanato cpanato deleted the GH-1024 branch June 19, 2021 09:54
tamalsaha added a commit to kubedb/apimachinery that referenced this pull request Sep 27, 2022
tamalsaha added a commit to kubedb/apimachinery that referenced this pull request Sep 27, 2022
tamalsaha added a commit to kubedb/apimachinery that referenced this pull request Sep 27, 2022
tamalsaha added a commit to kubedb/apimachinery that referenced this pull request Sep 27, 2022
tamalsaha added a commit to kubedb/apimachinery that referenced this pull request Sep 27, 2022
tamalsaha added a commit to kubedb/apimachinery that referenced this pull request Sep 30, 2022
tamalsaha added a commit to kubedb/apimachinery that referenced this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make --insecure flag's behavior equal to docker --insecure-registry flag.
3 participants