-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document released images in release notes #1069
Conversation
|
||
``` | ||
docker pull gcr.io/go-containerregistry/crane:{{.Tag}} | ||
docker pull gcr.io/go-containerregistry/gcrane:{{.Tag}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, the footer
part will be rendered as is (I didn't test, though).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find a better way of doing it, though - This change, as is, is still helpful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @zhouhaibing089! I'll wait for goreleaser/goreleaser#2326 to merge this. If it takes too long I'll update to not include the {{.Tag}}
since that's better than nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The referenced PR has now been merged. :)
Codecov Report
@@ Coverage Diff @@
## main #1069 +/- ##
=======================================
Coverage 75.50% 75.50%
=======================================
Files 107 107
Lines 5094 5094
=======================================
Hits 3846 3846
Misses 703 703
Partials 545 545 Continue to review full report at Codecov.
|
Fixes #1068