Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document released images in release notes #1069

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Jul 1, 2021

Fixes #1068


```
docker pull gcr.io/go-containerregistry/crane:{{.Tag}}
docker pull gcr.io/go-containerregistry/gcrane:{{.Tag}}
Copy link

@zhouhaibing089 zhouhaibing089 Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find a better way of doing it, though - This change, as is, is still helpful!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @zhouhaibing089! I'll wait for goreleaser/goreleaser#2326 to merge this. If it takes too long I'll update to not include the {{.Tag}} since that's better than nothing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referenced PR has now been merged. :)

@codecov-commenter
Copy link

Codecov Report

Merging #1069 (26545f7) into main (ce35c99) will not change coverage.
The diff coverage is n/a.

❗ Current head 26545f7 differs from pull request most recent head 303a8d5. Consider uploading reports for the commit 303a8d5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1069   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files         107      107           
  Lines        5094     5094           
=======================================
  Hits         3846     3846           
  Misses        703      703           
  Partials      545      545           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce35c99...303a8d5. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit 628a2ff into google:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Add published images in README
4 participants