Straighten out remote.List{WithContext} #1090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListWithContext
is kinda gross when we also haveList(..., remote.WithContext(ctx)
-- let's deprecate it.edit: the rest is no longer relevant, but useful for context:
This led a test to fail because the /v2/ request fails on a cancelled context, which I think is good because we shouldn't ignore the provided context for that ping request. In fixing that, I wanted to make the test check for whether the errorerrors.Is(context.Canceled)
, but that was stymied bytransport.NewTransportWithContext
losing that information when it does it's little multi-error thing.Gross.
So we have a couple options:
don't return multiple errors, maybeif logs.Enabled(logs.Debug) { logs.Debug.Printf("failed https, falling back to http") }
drop this whole thing,ListWithContext
is fine the way it is, and ignoring context to do the ping is fine.