Add static.NewLayer #1093
Merged
Add static.NewLayer #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1093 +/- ##
==========================================
+ Coverage 75.44% 75.49% +0.05%
==========================================
Files 107 108 +1
Lines 5159 5170 +11
==========================================
+ Hits 3892 3903 +11
Misses 714 714
Partials 553 553
Continue to review full report at Codecov.
|
| l := NewLayer(b, types.OCILayer) | ||
|
|
||
| // This does basically nothing. | ||
| if err := validate.Layer(l, validate.Fast); err != nil { |
There was a problem hiding this comment.
Why fast? You can drop half this test if you do standard.
There was a problem hiding this comment.
static_test.go:33: gzip: invalid header
There was a problem hiding this comment.
We should maybe fix that to actually look at media types (for +gzip)
There was a problem hiding this comment.
Do you want to do that? I'm fine just manually validating in this test for now.
jonjohnsonjr
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly copied from cosign, with basic tests, and a
sync.OncearoundDigest().