Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable codeql analysis #1135

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Re-enable codeql analysis #1135

merged 1 commit into from
Oct 1, 2021

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Oct 1, 2021

These were dropped in #1016 and I don't remember why. The result is that code scanning alerts have been disabled since May: https://github.com/google/go-containerregistry/security/code-scanning

@codecov-commenter
Copy link

Codecov Report

Merging #1135 (adccd1a) into main (308547a) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1135      +/-   ##
==========================================
- Coverage   75.41%   75.39%   -0.03%     
==========================================
  Files         108      108              
  Lines        7827     7827              
==========================================
- Hits         5903     5901       -2     
- Misses       1361     1363       +2     
  Partials      563      563              
Impacted Files Coverage Δ
pkg/v1/remote/multi_write.go 62.92% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308547a...adccd1a. Read the comment docs.

@imjasonh
Copy link
Collaborator Author

imjasonh commented Oct 1, 2021

No new issues found that haven't already been acked: https://github.com/google/go-containerregistry/security/code-scanning?query=pr%3A1135+

@imjasonh imjasonh merged commit 2459de3 into google:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants