Enable some more golangci-lint checks, fix findings #1164

imjasonh · 2021-11-04T14:20:22Z

There's still quite a bit of errchecks to chase down, but this is an
improvement at least.

god what a mind-numbing chore.

codecov-commenter · 2021-11-04T14:23:14Z

Codecov Report

Merging #1164 (c4b24b7) into main (dd49079) will not change coverage.
The diff coverage is 59.32%.

❗ Current head c4b24b7 differs from pull request most recent head f889c58. Consider uploading reports for the commit f889c58 to get more accurate results

@@           Coverage Diff           @@
##             main    #1164   +/-   ##
=======================================
  Coverage   75.22%   75.22%           
=======================================
  Files         108      108           
  Lines        7850     7850           
=======================================
  Hits         5905     5905           
  Misses       1379     1379           
  Partials      566      566

Impacted Files	Coverage Δ
pkg/legacy/tarball/write.go	`67.18% <0.00%> (ø)`
pkg/name/ref.go	`100.00% <ø> (ø)`
pkg/v1/cache/ro.go	`100.00% <ø> (ø)`
pkg/v1/google/list.go	`70.81% <0.00%> (ø)`
pkg/v1/layout/write.go	`47.92% <ø> (ø)`
pkg/v1/mutate/rebase.go	`46.73% <0.00%> (ø)`
pkg/v1/partial/index.go	`61.36% <0.00%> (ø)`
pkg/v1/remote/check.go	`70.00% <0.00%> (ø)`
pkg/v1/remote/transport/ping.go	`91.46% <ø> (-0.11%)`	⬇️
pkg/v1/mutate/mutate.go	`71.94% <33.33%> (ø)`
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd49079...f889c58. Read the comment docs.

pkg/gcrane/copy.go

pkg/name/errors.go

pkg/v1/google/keychain.go

pkg/v1/remote/descriptor_test.go

pkg/v1/remote/multi_write.go

mattmoor

I stopped commenting on them, but there were a bunch of // nolint errorlint that could be errors.As, and a license presubmit check, but otherwise this LGTM

There's still quite a bit of errchecks to chase down, but this is an improvement at least.

mattmoor · 2021-11-04T15:49:18Z

pkg/name/errors.go

-	_, ok := err.(*ErrBadName)
-	return ok
+	var berr *ErrBadName
+	return errors.As(err, &berr)


I believe this can just be errors.Is

I tried a bunch of different ways and couldn't get it to work.

It turns out this method is never used outside of tests in pkg/name, so I just removed it and inlined it (with errors.As for now) into the two places in tests where it was used. In theory someone is using it today, since it was exported. If we want I can put it back and deprecate it.

I also removed NewErrBadName which isn't used outside of pkg/name, and should not be needed outside of pkg/name.

pkg/v1/remote/descriptor_test.go

pkg/name/errors.go

imjasonh requested a review from mattmoor November 4, 2021 14:20