Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a new remote.DefaultTransport. #1165

Merged
merged 4 commits into from
Nov 11, 2021

Commits on Nov 10, 2021

  1. Revert "Give the ping context a timeout. (google#1163)"

    This reverts commit 080751a.
    mattmoor committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    396766a View commit details
    Browse the repository at this point in the history
  2. Define a new remote.DefaultTransport.

    Previously we used `http.DefaultTransport` (on which this is based),
    but this uses a default dial timeout of 30s, which when we (by default)
    wrap things in 5x retries can lead to ~150s delays simply pinging
    an http-based registry.
    
    If folks encounter issues with this via the library they can restore
    the current behavior with:
    ```go
    remote.WithTransport(http.DefaultTransport)
    ```
    
    If folks encounter issues with this via `crane` they can restore the
    current behavior with:
    ```
    --dial-timeout 30s
    ```
    mattmoor committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    7df8286 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    32a378d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Back out the crane flag

    mattmoor committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    3997975 View commit details
    Browse the repository at this point in the history