Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Check for Podman's auth.json in DefaultKeychain (#1181)" #1184

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

imjasonh
Copy link
Collaborator

This reverts commit 309df09.

Fixes #1183

@codecov-commenter
Copy link

Codecov Report

Merging #1184 (1318ce5) into main (c90c444) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
+ Coverage   75.16%   75.24%   +0.08%     
==========================================
  Files         108      108              
  Lines        7879     7856      -23     
==========================================
- Hits         5922     5911      -11     
+ Misses       1388     1379       -9     
+ Partials      569      566       -3     
Impacted Files Coverage Δ
pkg/authn/keychain.go 100.00% <100.00%> (+24.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90c444...1318ce5. Read the comment docs.

@imjasonh imjasonh merged commit bce5496 into google:main Nov 17, 2021
imjasonh added a commit to imjasonh/go-containerregistry that referenced this pull request Nov 17, 2021
imjasonh added a commit that referenced this pull request Nov 17, 2021
* Revert "Revert "Check for Podman's auth.json in DefaultKeychain (#1181)" (#1184)"

This reverts commit bce5496.

* Attempt 2: Check for Podman's auth in DefaultKeychain

* go mod download in k8schain to pick up the new dep

* remove some debug logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crane Login auth failing
3 participants