Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add depcheck test that pkg/registry has light dependencies #1187

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Nov 18, 2021

Also depcheck that cmd/{g}crane doesn't depend on pkg/v1/daemon

#1166

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #1187 (3b91041) into main (6a419dc) will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1187      +/-   ##
==========================================
- Coverage   75.18%   74.90%   -0.29%     
==========================================
  Files         108      110       +2     
  Lines        7887     7925      +38     
==========================================
+ Hits         5930     5936       +6     
- Misses       1387     1419      +32     
  Partials      570      570              
Impacted Files Coverage Δ
cmd/gcrane/main.go 10.71% <0.00%> (ø)
cmd/crane/main.go 30.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a419dc...3b91041. Read the comment docs.

@imjasonh imjasonh merged commit 843455e into google:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants