Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept multiple entrypoint values in crane mutate #1194

Merged
merged 8 commits into from
Dec 3, 2021

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Dec 1, 2021

$ crane config $(
    go run ./cmd/crane mutate \
      --entrypoint=dotnet,craneapp.dll \
      phillipsj/craneapp:0.1.0 \
      -t gcr.io/imjasonh/craneapp:0.1.0) | jq .config.Entrypoint
...
[
  "dotnet",
  "craneapp.dll"
]

This might fix the issue with malformed Windows images created by crane mutate --entrypoint, based on Jon's findings -- moby/moby#33373 (comment)

cc @phillipsj

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #1194 (c6c7d5a) into main (63e6f4e) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1194   +/-   ##
=======================================
  Coverage   74.75%   74.76%           
=======================================
  Files         111      111           
  Lines        8007     8008    +1     
=======================================
+ Hits         5986     5987    +1     
  Misses       1441     1441           
  Partials      580      580           
Impacted Files Coverage Δ
internal/windows/windows.go 67.69% <75.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e6f4e...c6c7d5a. Read the comment docs.

@phillipsj
Copy link
Contributor

It's a different error, but similar.

docker: Error response from daemon: container 1be3653576f6a0a277ec17ad3f53ab2e867bf33adac0bade67be858480ea194a encountered an error during hcsshim::System::CreateProcess: failure in a Windows system call: The system cannot find the file specified. (0x2)
[Event Detail:  Provider: 00000000-0000-0000-0000-000000000000]
[Event Detail:  Provider: 00000000-0000-0000-0000-000000000000]
[Event Detail: onecore\vm\compute\management\orchestration\vmhostedcontainer\processmanagement.cpp(173)\vmcomputeagent.exe!00007FF78DF4EFBD: (caller: 00007FF78DEF4E97) Exception(2) tid(3c0) 80070002 The system cannot find the file specified.
    CallContext:[\Bridge_ProcessMessage\VmHostedContainer_ExecuteProcess]
 Provider: 00000000-0000-0000-0000-000000000000].

Also add e2e test that runs an image produced by crane append+mutate.
@imjasonh imjasonh merged commit c75901c into google:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants