Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use basic for anonymous pings #1207

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

Previously we would eschew any kind of wrapper if the ping returned a
200, but this means we don't correctly respond to challenges after the
initial ping. This is a half-fix, but for now we just assume basic if
the ping returns a 200 so that (at least) basic auth registries will
work.

Previously we would eschew any kind of wrapper if the ping returned a
200, but this means we don't correctly respond to challenges after the
initial ping. This is a half-fix, but for now we just assume basic if
the ping returns a 200 so that (at least) basic auth registries will
work.
@codecov-commenter
Copy link

Codecov Report

Merging #1207 (93de556) into main (379f5ca) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
- Coverage   74.55%   74.55%   -0.01%     
==========================================
  Files         111      111              
  Lines        8050     8048       -2     
==========================================
- Hits         6002     6000       -2     
  Misses       1464     1464              
  Partials      584      584              
Impacted Files Coverage Δ
pkg/v1/remote/transport/transport.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379f5ca...93de556. Read the comment docs.

@imjasonh imjasonh merged commit 0e44871 into google:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants