Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crane pull: support pulling index to OCI Layout #1215

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

jonjohnsonjr
Copy link
Collaborator

Prior to this, we'd also resolve an index to an image when using crane
pull. For OCI Layouts, we can actually pull the whole index, so when
--format=oci and --platform is unset, just do that.

cmd/crane/cmd/pull.go Show resolved Hide resolved
cmd/crane/cmd/pull.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1215 (6c460a5) into main (c636644) will increase coverage by 0.00%.
The diff coverage is 80.00%.

❗ Current head 6c460a5 differs from pull request most recent head 7912700. Consider uploading reports for the commit 7912700 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1215   +/-   ##
=======================================
  Coverage   73.79%   73.80%           
=======================================
  Files         111      111           
  Lines        8188     8191    +3     
=======================================
+ Hits         6042     6045    +3     
  Misses       1549     1549           
  Partials      597      597           
Impacted Files Coverage Δ
pkg/crane/pull.go 69.44% <80.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c636644...7912700. Read the comment docs.

Prior to this, we'd also resolve an index to an image when using crane
pull. For OCI Layouts, we can actually pull the whole index, so when
--format=oci and --platform is unset, just do that.
@jonjohnsonjr jonjohnsonjr marked this pull request as ready for review January 5, 2022 21:50
@jonjohnsonjr jonjohnsonjr merged commit d9bfbcb into google:main Jan 5, 2022
@jonjohnsonjr jonjohnsonjr deleted the layout-pull branch January 5, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants