Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Temp File For layout.{Write,Append,Replace} Image/Index Methods #1226

Merged
merged 9 commits into from
Jan 8, 2022

Commits on Jan 6, 2022

  1. Add layout.WriteLayer for streaming layers and undersized layers from…

    … incomplete downloads
    
    WriteLayer is an alternative to WriteBlob which can be used with
    streaming layers which have not yet calculated a digest or size. A
    temporary file is first written and then renamed when the reader has
    been fully consumed. Also, existing layers which do not have the correct
    size (and thus invalid hashes, but the hash is not checked) are
    overwritten.
    
    {Append,Replace,Write}{Image,Layer} functions utilize WriteLayer instead
    of WriteBlob to correctly overwrite undersized layers which were
    previously ignored without error. Undersized layers should no longer
    occur, since WriteLayer writes to a temporary file first, but when
    WriteBlob was used, these were common due to incomplete downloads.
    ben-krieger committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    6ffd378 View commit details
    Browse the repository at this point in the history
  2. Improve error messages for validate.Image and validate.Index when lay…

    …er blob content is truncated
    ben-krieger committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    a559ccd View commit details
    Browse the repository at this point in the history
  3. Unexport layout.WriteLayer; Implement suggested changes for validat…

    …eLayers and temp file naming
    ben-krieger committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    ab33ba1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4d9503b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    575f86d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1efe3ef View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Configuration menu
    Copy the full SHA
    b2322b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ecf1181 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c3cdb6 View commit details
    Browse the repository at this point in the history