Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing ECR authentication. #1237

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Start testing ECR authentication. #1237

merged 1 commit into from
Jan 7, 2022

Conversation

mattmoor
Copy link
Collaborator

@mattmoor mattmoor commented Jan 7, 2022

This uses github OIDC federation to impersonate an AWS role on an account owned by Chainguard, Inc. that I created for the sole purpose of testing this.

This tests both crane with the ecr-login credential helper and krane with the k8schain library.

WIP is until this uses pull_request_target

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #1237 (b3a7066) into main (842ede7) will not change coverage.
The diff coverage is n/a.

❗ Current head b3a7066 differs from pull request most recent head 045eb15. Consider uploading reports for the commit 045eb15 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1237   +/-   ##
=======================================
  Coverage   73.77%   73.77%           
=======================================
  Files         111      111           
  Lines        8183     8183           
=======================================
  Hits         6037     6037           
  Misses       1549     1549           
  Partials      597      597           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842ede7...045eb15. Read the comment docs.

This uses github OIDC federation to impersonate an AWS role on an account owned by Chainguard, Inc. that I created for the sole purpose of testing this.

This tests both `crane` with the `ecr-login` credential helper and `krane` with the `k8schain` library.
@mattmoor mattmoor changed the title [WIP] Start testing ECR authentication. Start testing ECR authentication. Jan 7, 2022
@mattmoor
Copy link
Collaborator Author

mattmoor commented Jan 7, 2022

This won't show up (yet) because it is pull_request_target, but I used a branch on the main repo and pull_request to confirm it works:
image

@mattmoor mattmoor merged commit c370fbd into main Jan 7, 2022
@mattmoor mattmoor deleted the ecr-auth-testing branch January 7, 2022 17:37
run: go install .

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@master
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have caught this: aws-actions/configure-aws-credentials@v1.6.0 here and below. Dependabot should help us keep it up to date.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants