-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start testing ECR authentication. #1237
Conversation
b3a7066
to
1a92700
Compare
Codecov Report
@@ Coverage Diff @@
## main #1237 +/- ##
=======================================
Coverage 73.77% 73.77%
=======================================
Files 111 111
Lines 8183 8183
=======================================
Hits 6037 6037
Misses 1549 1549
Partials 597 597 Continue to review full report at Codecov.
|
1a92700
to
a129357
Compare
This uses github OIDC federation to impersonate an AWS role on an account owned by Chainguard, Inc. that I created for the sole purpose of testing this. This tests both `crane` with the `ecr-login` credential helper and `krane` with the `k8schain` library.
a129357
to
045eb15
Compare
run: go install . | ||
|
||
- name: Configure AWS Credentials | ||
uses: aws-actions/configure-aws-credentials@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have caught this: aws-actions/configure-aws-credentials@v1.6.0
here and below. Dependabot should help us keep it up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses github OIDC federation to impersonate an AWS role on an account owned by Chainguard, Inc. that I created for the sole purpose of testing this.
This tests both
crane
with theecr-login
credential helper andkrane
with thek8schain
library.WIP is until this uses
pull_request_target