Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmd/krane/go.mod and include it in hack/presubmit.sh #1240

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

imjasonh
Copy link
Collaborator

This caused a CI failure in #1239

@imjasonh
Copy link
Collaborator Author

imjasonh commented Jan 10, 2022

The CI still fails: https://github.com/google/go-containerregistry/runs/4764050886?check_suite_focus=true

go: updates to go.mod needed; to update it:
	go mod tidy
- name: Install krane
  working-directory: ./cmd/krane
  run: go install .

(This doesn't fail locally)

I think this is because it's pull_request_target and pulling source from main and not the PR contents?

Yep, the logs:

Checking out the ref
/usr/bin/git log -1 --format='%H'
'a61fd0a8e2bb2c0c187ab138aff426be8b3210d6'

@mattmoor mattmoor merged commit a2e5b9e into google:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants