Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ecr-login to v0.6.0 #1243

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Bump ecr-login to v0.6.0 #1243

merged 2 commits into from
Jan 14, 2022

Conversation

imjasonh
Copy link
Collaborator

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #1243 (b052bb0) into main (a2e5b9e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   73.87%   73.84%   -0.03%     
==========================================
  Files         111      111              
  Lines        8263     8263              
==========================================
- Hits         6104     6102       -2     
- Misses       1557     1559       +2     
  Partials      602      602              
Impacted Files Coverage Δ
pkg/v1/remote/multi_write.go 62.92% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e5b9e...b052bb0. Read the comment docs.

@imjasonh
Copy link
Collaborator Author

@mattmoor ECR tests failing with:

OpenIDConnect provider's HTTPS certificate doesn't match configured thumbprint

And also some mysterious Go modules failure for go install ./cmd/krane I can't seem to reproduce locally. 🤔

@dprotaso
Copy link
Contributor

This is a big feature 🎉

Feature - Added support to assume roles via EC2 instance metadata.

@dprotaso
Copy link
Contributor

/approve

@imjasonh imjasonh merged commit 890d5b3 into google:main Jan 14, 2022
@mattmoor
Copy link
Collaborator

@imjasonh ah, let me regenerate it. I hate the thumbprint shit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants