Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return transport errors that support errors.Is #1244

Merged
merged 2 commits into from
Jan 14, 2022
Merged

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jan 14, 2022

Previously timed out requests could be checked using errors.Is(err, context. DeadlineExceeded)

That changed when multiple errors were returned in an earlier PR. This change introduces Uber's multi-err library that coalesces errors and supports error.Is

@codecov-commenter
Copy link

Codecov Report

Merging #1244 (9b514d6) into main (a2e5b9e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 9b514d6 differs from pull request most recent head 05d164f. Consider uploading reports for the commit 05d164f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1244      +/-   ##
==========================================
- Coverage   73.87%   73.84%   -0.03%     
==========================================
  Files         111      111              
  Lines        8263     8263              
==========================================
- Hits         6104     6102       -2     
- Misses       1557     1559       +2     
  Partials      602      602              
Impacted Files Coverage Δ
pkg/v1/remote/transport/ping.go 91.46% <100.00%> (ø)
pkg/v1/remote/multi_write.go 62.92% <0.00%> (-0.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e5b9e...05d164f. Read the comment docs.

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@imjasonh imjasonh merged commit 62eaac0 into google:main Jan 14, 2022
@dprotaso dprotaso deleted the error-is branch January 14, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants