pkg/authn: return Anonymous on podman auth.json errors #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to what happens when the package looks for Docker's config.json, it ignores any error (not found, permissions denied, …) and pass on. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #1248 +/- ##
==========================================
+ Coverage 73.77% 73.80% +0.02%
==========================================
Files 111 111
Lines 8285 8283 -2
==========================================
+ Hits 6112 6113 +1
+ Misses 1571 1569 -2
+ Partials 602 601 -1
Continue to review full report at Codecov.
|
|
Amazing, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to what happens when the package looks for Docker's
config.json, it ignores any error (not found, permissions denied, …)
and pass on.
This should help tektoncd/chains#320 not to happen for example.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/cc @imjasonh @mattmoor @concaf