-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pkg/authn/github.Keychain to authenticate with ghcr.io #1252
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
- Coverage 73.92% 73.82% -0.11%
==========================================
Files 111 112 +1
Lines 8345 8301 -44
==========================================
- Hits 6169 6128 -41
+ Misses 1573 1571 -2
+ Partials 603 602 -1
Continue to review full report at Codecov.
|
@@ -51,6 +52,7 @@ func main() { | |||
keychain := authn.NewMultiKeychain( | |||
authn.DefaultKeychain, | |||
google.Keychain, | |||
github.Keychain, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was gonna be my feedback. Now I’m regretting not calling this omicrane after all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only been released once as krane
, you can change it.
Ooooooor, release it as github.com/mattmoor/omnicrane
instead... 😈
7003666
to
25e097a
Compare
@jonjohnsonjr ping |
- if GITHUB_TOKEN env var is set, and registry is ghcr.io, use the token as a password. - if GITHUB_ACTOR env var is set, use it for the auth username.
25e097a
to
7fbd4f4
Compare
Fixes #1251