Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that layer is closed before renaming file in layout #1254

Merged

Conversation

ben-krieger
Copy link
Contributor

Fixes #1253

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2022

Codecov Report

Merging #1254 (56d378f) into main (86ab606) will increase coverage by 0.03%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1254      +/-   ##
==========================================
+ Coverage   73.74%   73.77%   +0.03%     
==========================================
  Files         111      111              
  Lines        8283     8286       +3     
==========================================
+ Hits         6108     6113       +5     
+ Misses       1573     1571       -2     
  Partials      602      602              
Impacted Files Coverage Δ
pkg/v1/layout/write.go 48.88% <40.00%> (-0.48%) ⬇️
pkg/v1/stream/layer.go 87.66% <0.00%> (+3.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ab606...56d378f. Read the comment docs.

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the quick fix! 🙏

@imjasonh imjasonh merged commit 1283f38 into google:main Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestStreamingWriteLayer: value not computed until stream is consumed
3 participants