Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix krane:debug image to include shell #1264

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

imjasonh
Copy link
Collaborator

KO_CONFIG_PATH=./.ko/debug was being interpreted as relative to cmd/krane when we cd'd into it. Making it an absolute path fixes this.

Fixes #1262

Tested locally and produced gcr.io/imjasonh/krane:debug:

$ docker run --rm --entrypoint sh gcr.io/imjasonh/krane:debug -c "ls /"
bin
boot
busybox
...

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #1264 (17ae660) into main (03d4ad1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   73.77%   73.77%           
=======================================
  Files         111      111           
  Lines        8286     8286           
=======================================
  Hits         6113     6113           
  Misses       1571     1571           
  Partials      602      602           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d4ad1...17ae660. Read the comment docs.

@mattmoor mattmoor merged commit 3a2a6f1 into google:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shell to krane:debug
3 participants