Fallback to anonymous if env or gcloud are not configured #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1279 +/- ##
=======================================
Coverage 73.98% 73.99%
=======================================
Files 112 112
Lines 8364 8367 +3
=======================================
+ Hits 6188 6191 +3
Misses 1573 1573
Partials 603 603
Continue to review full report at Codecov.
|
imjasonh
added a commit
to imjasonh/ko
that referenced
this pull request
Feb 3, 2022
imjasonh
added a commit
to imjasonh/ko
that referenced
this pull request
Feb 3, 2022
Debug-log env or gcloud errors instead of returning an error
imjasonh
force-pushed
the
google-anonymous
branch
from
b9dd8de to
0b4f249
Compare
jonjohnsonjr
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
google.Keychainis used withNewMultiKeychain, it will be selected to provide credentials to pull or push images for images in GCR/AR. If, in this case, Application Default Credentials aren't configured andgcloudis not available or configured to provide credentials, the keychain will fail, even if the image is otherwise publicly available.With this change, if the env credential lookup and
gcloudcredential lookup both fail, instead of returning an error,google.Keychainwill fallback to returnauthn.Anonymousinstead. In this case,NewMultiKeychainwill fall through each option in turn, until finally usingauthn.Anonymousif none match and provide credentials.