Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crane): allow setting the repository to push by digest #1323

Merged
merged 4 commits into from
May 10, 2022

Conversation

lippertmarkus
Copy link
Contributor

Signed-off-by: Markus Lippert lippertmarkus@gmx.de

Signed-off-by: Markus Lippert <lippertmarkus@gmx.de>
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #1323 (15a3fb5) into main (f1fa40b) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 15a3fb5 differs from pull request most recent head f1d57ab. Consider uploading reports for the commit f1d57ab to get more accurate results

@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
+ Coverage   74.07%   74.19%   +0.12%     
==========================================
  Files         112      113       +1     
  Lines        8385     8436      +51     
==========================================
+ Hits         6211     6259      +48     
- Misses       1570     1571       +1     
- Partials      604      606       +2     
Impacted Files Coverage Δ
pkg/v1/remote/options.go 71.81% <0.00%> (-2.23%) ⬇️
pkg/v1/config.go 75.00% <0.00%> (ø)
pkg/v1/remote/transport/transport.go 100.00% <0.00%> (ø)
pkg/authn/authn.go 100.00% <0.00%> (ø)
pkg/v1/remote/transport/bearer.go 78.10% <0.00%> (+0.21%) ⬆️
pkg/v1/random/index.go 74.13% <0.00%> (+0.45%) ⬆️
pkg/v1/remote/transport/useragent.go 50.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1fa40b...f1d57ab. Read the comment docs.

Signed-off-by: Markus Lippert <lippertmarkus@gmx.de>
@lippertmarkus
Copy link
Contributor Author

@imjasonh as Jon is on parental leave, anyone else who could bring this forward?

cmd/crane/cmd/mutate.go Outdated Show resolved Hide resolved
@imjasonh
Copy link
Collaborator

@imjasonh as Jon is on parental leave, anyone else who could bring this forward?

Thanks for the ping, I can keep up on this.

Co-authored-by: Jason Hall <jasonhall@redhat.com>
Signed-off-by: Markus Lippert <lippertmarkus@gmx.de>
@lippertmarkus
Copy link
Contributor Author

Do you know why the Windows e2e test is failing?

@imjasonh
Copy link
Collaborator

Do you know why the Windows e2e test is failing?

Nope. It definitely seems unrelated, if it keeps happening I don't mind merging this PR past it.

@lippertmarkus
Copy link
Contributor Author

Then let's go like this

@imjasonh imjasonh merged commit b7619f2 into google:main May 10, 2022
@lippertmarkus lippertmarkus deleted the feat-crane-mutate-repo branch May 10, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants