use k8s keychain first #1346
Merged
use k8s keychain first #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up instances where the credentials are in image pull secrets
imjasonh
reviewed
Apr 13, 2022
Comment on lines
+49
to
50
| k8s, | ||
| authn.DefaultKeychain, |
There was a problem hiding this comment.
Suggested change
| k8s, | |
| authn.DefaultKeychain, | |
| authn.DefaultKeychain, | |
| k8s, |
I think we may still want the default keychain first, and it should at least be much quicker than the others, barring any cred helper shenanigans.
WDYT?
There was a problem hiding this comment.
I'm ok with that .
Just be aware that if you're testing k8schain (pulling from creds from secrets) and you're hitting a real cluster you'll want to docker logout beforehand :)
There was a problem hiding this comment.
nvm, I think I'm becoming convinced that k8s belongs first, since it eliminates the issue with slow cred helpers and potential confusion with local testing. Let's keep k8s first. (Sorry for the review churn)
dprotaso
force-pushed
the
k8s-lookup-first
branch
from
60a1755
to
ba384b3
Compare
|
ok k8s is first now |
imjasonh
approved these changes
Apr 13, 2022
This was referenced May 16, 2022
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up instances where the credentials are in image pull secrets