Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ConfigFile): Add Variant #1362

Merged
merged 1 commit into from
May 10, 2022

Conversation

lippertmarkus
Copy link
Contributor

@lippertmarkus lippertmarkus commented May 10, 2022

Signed-off-by: Markus Lippert lippertmarkus@gmx.de

By mutating an image, the configfile is copied. When the source image is e.g. linux/arm/v7 the variant is currently not copied as its not part of the ConfigFile struct.

This field is usually part of the config https://github.com/opencontainers/image-spec/blob/main/image-index.md#platform-variants:
crane config mcr.microsoft.com/dotnet/runtime-deps:6.0-alpine-arm64v8

{
     ...
     "architecture": "arm64",
     "os": "linux",
+    "variant": "v8"
}

Signed-off-by: Markus Lippert <lippertmarkus@gmx.de>
Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is indeed specified: https://github.com/opencontainers/image-spec/blob/main/config.md

  • variant string, OPTIONAL
    The variant of the specified CPU architecture. Configurations SHOULD use, and implementations SHOULD understand, variant values listed in the Platform Variants table.

@imjasonh imjasonh merged commit ba4080b into google:main May 10, 2022
@lippertmarkus lippertmarkus deleted the feat-configFile-Variant branch May 10, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants