Allow config files to be mounted #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we wanted to reuse the layer uploading code, we wrap the config bytes up as a Layer. Unfortunately, the partial.ConfigLayer implementation doesn't preserve the fact that for mountable images, we can perform a cross-repo mount. This change updates partial.ConfigLayer to look for a ConfigLayer implementation on the given image to see if it can simply dispatch to that, falling back to calculating it from the config bytes otherwise.
Codecov Report
@@ Coverage Diff @@
## main #1387 +/- ##
=======================================
Coverage 74.19% 74.19%
=======================================
Files 113 113
Lines 8458 8470 +12
=======================================
+ Hits 6275 6284 +9
- Misses 1575 1577 +2
- Partials 608 609 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we wanted to reuse the layer uploading code, we wrap the config
bytes up as a Layer. Unfortunately, the partial.ConfigLayer
implementation doesn't preserve the fact that for mountable images, we
can perform a cross-repo mount.
This change updates partial.ConfigLayer to look for a ConfigLayer
implementation on the given image to see if it can simply dispatch to
that, falling back to calculating it from the config bytes otherwise.