Implement cross-registry blob mounting experiment #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently only implemented by Google but we'd like to upstream this to the distribution spec. There's a small possibility that this will break registries that don't implement the spec properly. We signal the domain of the origin registry with the "origin" querystring parameter.
|
Picking up #1322 |
Codecov Report
@@ Coverage Diff @@
## main #1388 +/- ##
=======================================
Coverage 74.19% 74.19%
=======================================
Files 113 113
Lines 8458 8460 +2
=======================================
+ Hits 6275 6277 +2
Misses 1575 1575
Partials 608 608
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Jun 16, 2022
dmikusa
pushed a commit
to paketo-buildpacks/pipeline-builder
that referenced
this pull request
Jul 13, 2022
Functionality was added in crane to support cross-registry blob mounting, but it seems to cause issues with Harbor registry (and possibly others). Rolling back for stability. We'll need to revisit this in the future. google/go-containerregistry#1388 To reproduce the problem: 1. `crane cp` an image to a Harbor registry that is not currently in the registry 2. It'll fail saying `Error: failed to copy image: POST` and `UNAUTHORIZED: project foo not found: project foo not found`. This should be retested before bumping the version of crane. Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently only implemented by Google but we'd like to upstream
this to the distribution spec. There's a small possibility that this
will break registries that don't implement the spec properly.
We signal the domain of the origin registry with the "origin"
querystring parameter.
Fixes #1321
Likely breaks with harbor because of #219 but they SHOULD be returning a 202 here.