Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump deps using ./hack/bump-deps.sh #1389

Merged
merged 5 commits into from
Jul 13, 2022
Merged

Conversation

imjasonh
Copy link
Collaborator

No description provided.

@konrad945
Copy link

Hi, @imjasonh @jonjohnsonjr what is the status of this review? It's open for some time and it fixes some CVEs (docker) that I would like to fix in my project.

@imjasonh
Copy link
Collaborator Author

imjasonh commented Jul 13, 2022

The sigs.k8s.io/json dep that gets bumped here replaced interface{} with any, introduced in Go 1.18.

kubernetes-sigs/json#14

Diff:
kubernetes-sigs/json@227cbc7...ff3dbbe

We can either:

  • not bump the dep; future ./hack/bump-deps.shes will bump it again
  • replace our dep back to the one that uses interface{}; users who depend on this won't pick up our replace, and users who go install github.com/google/go-containerregistry/cmd/crane won't get the replace, and will fail if they're building with Go <1.18
  • assert that we can only be built with Go 1.18+, update CI accordingly, wait for 1.19 (currently in RC2) so that we can say we still support the last two Go releases.

@jonjohnsonjr
Copy link
Collaborator

I'm ok with requiring 1.18.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #1389 (840af34) into main (ddd39fb) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 840af34 differs from pull request most recent head 0c4b91c. Consider uploading reports for the commit 0c4b91c to get more accurate results

@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
- Coverage   74.16%   74.13%   -0.04%     
==========================================
  Files         114      114              
  Lines        8459     8459              
==========================================
- Hits         6274     6271       -3     
- Misses       1579     1581       +2     
- Partials      606      607       +1     
Impacted Files Coverage Δ
pkg/v1/remote/transport/useragent.go 41.17% <0.00%> (-8.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd39fb...0c4b91c. Read the comment docs.

@imjasonh imjasonh merged commit e7a9f2b into google:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants