-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the platform specific authentication of krane in "auth get" command #1413
Conversation
This is really interesting! So the idea is that with this change, I think we'll want a simple end-to-end test of this behavior, for GHCR and ECR at least. For ECR, that means calling Could you add that to this PR? |
Codecov Report
@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
- Coverage 73.38% 73.38% -0.01%
==========================================
Files 115 115
Lines 8747 8750 +3
==========================================
+ Hits 6419 6421 +2
- Misses 1687 1688 +1
Partials 641 641
|
@imjasonh Sure. I have just added the tests. Previously,
But, I added to another way to specify the registry address as an argument as follows:
|
Thanks for this change, this is awesome. If I had the time, I would set up workload identity so that we could test Looks like you just need to regenerate the docs for the presubmit. |
This PR enables to work "auth get" command with the platform specific keychains given in
krane
tool.