-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consider base image media type when appending layers #1437
Conversation
How about At some point we might have a |
I agree.
This is a bit unclear I think. |
|
I am not sure why the unit test is failing. do you have any pointers? using go1.19 locally. |
fixed the unit test. should be ready now |
pkg/crane/append.go
Outdated
@@ -47,9 +48,25 @@ func Append(base v1.Image, paths ...string) (v1.Image, error) { | |||
return nil, fmt.Errorf("getting base image: %w", err) | |||
} | |||
|
|||
if base == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isWindows
checks for img==nil
already, we could remove that and put the == nil
check before isWindows
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it
Codecov Report
@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
- Coverage 73.40% 73.31% -0.10%
==========================================
Files 115 115
Lines 8757 8772 +15
==========================================
+ Hits 6428 6431 +3
- Misses 1688 1696 +8
- Partials 641 645 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
As discussed with @jonjohnsonjr. We still need to bikeshed name for the new
--oci
flag.Closes #1427