-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement crane index subcommand #1561
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1561 +/- ##
==========================================
+ Coverage 72.75% 72.91% +0.15%
==========================================
Files 118 118
Lines 9236 9408 +172
==========================================
+ Hits 6720 6860 +140
- Misses 1831 1856 +25
- Partials 685 692 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c621033
to
9b77df4
Compare
I gave Jon badly worded feedback that made him split the one command he'd created into two separate commands 😭 "filter" for something that mutates seems like an odd word choice - his original choice was IMO something like I'm sorry I made this harder Jon 😭 ❤️ 🙇 |
Don't beat yourself up @tianon 😄, I recommended I think I like having Since |
crane index filter allows platform-based filtering of manifests in an index. This is primarily useful for folks who want to use only some entries in a base image without having to copy irrelevant platforms. crane index append allows appending manifests to an existing index or creating a new index from scratch.
There is some special handling around "all" that I left in place, but at least we can drop some of this code.
f8186de
to
4bfc05f
Compare
@thesayyn FYI, would be interested in your feedback. I'm not sure if I'm ready to go full-on CEL integration :P |
sorry, I was off last week due to the earthquake. this looks as good as it could get without having a DSL or using CEL. |
crane index filter allows platform-based filtering of manifests in an index. This is primarily useful for folks who want to use only some entries in a base image without having to copy irrelevant platforms.
crane index append allows appending manifests to an existing index or creating a new index from scratch.
Fixes #1144
Fixes #1143
Fixes #1557
See also:
append
command - ease the process to push manifests to remote registries from a set of images #891crane amend
#1144 (comment)