Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crane: add --flatten for index append #1566

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

jonjohnsonjr
Copy link
Collaborator

While it's possible that folks might want to append an index to an index, it's more likely that they would want to merge them. This flag gives them an option to do either.

While it's possible that folks might want to append an index to an
index, it's more likely that they would want to merge them. This flag
gives them an option to do either.
@tianon
Copy link
Contributor

tianon commented Feb 16, 2023

I've tested this successfully with a list of images that contains both indexes and a non-index manifest and it flattened correctly 👀

cmd/crane/cmd/index.go Outdated Show resolved Hide resolved
Co-authored-by: Jason Hall <jason@chainguard.dev>
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Merging #1566 (72bade8) into main (3624968) will not change coverage.
The diff coverage is n/a.

❗ Current head 72bade8 differs from pull request most recent head 72dda39. Consider uploading reports for the commit 72dda39 to get more accurate results

@@           Coverage Diff           @@
##             main    #1566   +/-   ##
=======================================
  Coverage   72.95%   72.95%           
=======================================
  Files         118      118           
  Lines        9417     9417           
=======================================
  Hits         6870     6870           
  Misses       1855     1855           
  Partials      692      692           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonjohnsonjr jonjohnsonjr merged commit 4e95ae2 into google:main Feb 23, 2023
@jonjohnsonjr jonjohnsonjr deleted the flat-append branch February 23, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants