Update descriptor "data" field (when valid) during "crane edit config" #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
jonjohnsonjr
approved these changes
Mar 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 72.92% 72.88% -0.04%
==========================================
Files 118 118
Lines 9417 9422 +5
==========================================
Hits 6867 6867
- Misses 1857 1861 +4
- Partials 693 694 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1552
(I opted not to base this on top of #1583, but I'm happy to adjust if that's preferred or rebase/update after it is 😅)
Of course, happy to rebase, amend, adjust, close, etc as desired. 🙇