Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add crane auth logout #1589

Merged
merged 1 commit into from
Apr 20, 2023
Merged

add crane auth logout #1589

merged 1 commit into from
Apr 20, 2023

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Mar 9, 2023

Fixes #1587

NB: This doesn't clear creds from Podman-configured auth, which authn.DefaultKeychain uses if a Docker config file isn't found. This might be confusing, but crane auth login doesn't use that either, so 馃し.

It might make more sense to always login using DOCKER_CONFIG and logout of Docker- or Podman-configured auth, feedback welcome.

@codecov-commenter
Copy link

Codecov Report

Merging #1589 (89caef3) into main (ff810c1) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
+ Coverage   72.88%   72.91%   +0.03%     
==========================================
  Files         118      118              
  Lines        9422     9422              
==========================================
+ Hits         6867     6870       +3     
+ Misses       1861     1859       -2     
+ Partials      694      693       -1     
Impacted Files Coverage 螖
pkg/v1/remote/write.go 62.84% <0.00%> (+0.41%) 猬嗭笍

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@imjasonh
Copy link
Collaborator Author

imjasonh commented Mar 9, 2023

Some things I've learned about the Erase method, and by extension, docker logout:

  • it doesn't unset cred helpers for the server
  • it doesn't complain if creds already aren't defined for the server

I think I'd like to fix both of those for crane auth logout, but I'd be willing to be convinced that following docker's behavior exactly is better.

@jonjohnsonjr jonjohnsonjr merged commit df518f9 into google:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

question: crane auth logout
3 participants